Where do I see those in the PR?
I did not change them now. I just want to know if there is something to do with before lauch.
The LICENSE is the right one. As for the Makefile, I don’t know if it is used
1 Like
- Add files to the github action for testing
- Correct tests behaviour when an atom is expected and the solution returns
empty
@ErikSchierboom
I could not make the github action for test works properly, Could you please review it and see if I’ve made any mistakes?
@andradefr8 The test script was missing the executable bit. I’ve fixed it in: GitHub Actions Testing Files and Bug Fixes by eNascimento178 · Pull Request #97 · exercism/j · GitHub
Other than that, nice work! I’ve approved
1 Like
I believe that with this PR i completed all steps listed here necessary for lauch.
If there is something else, let me know.
I’ve made this post to try get other reviews about.
1 Like