I’d like to add a PR to include typing/gradual at config.json | Exercism's Docs to support the most appropriate tag for the upcoming GDScript track. What do you think?
3 Likes
Sorry, I just found config: should add `typing/gradual` as a valid `tag` · Issue #480 · exercism/docs · GitHub . I see it’s actually already implemented in the linter, just needs a change to the docs.
PR created: Update config-json.md by codingthat · Pull Request #581 · exercism/docs · GitHub
In general, please get approval for making a change before opening a PR.
Ah, sorry, I had actually even worded it that way first this time. But then I thought it didn’t make sense since a) there’s already an issue open for it and b) the corresponding change has already been merged in configlet, so I didn’t think there was any room for discussion (like…is it actually on the table to unmerge the configlet support? To me this appeared to be a half implementation of something already decided a long time ago.)
Anyway, I will err on the side of discussion even in this case going forward. Thanks for clarifying.
2 Likes
I mean Erik has already kind of pre-approved the tag to be added. Mostly just looks like the pr for the docs got lost or something, it is also 1 line pr.
But also just so things doesn’t get lost further. I believe a filter for this also has to be added on the website.
3 Likes
I agree that in this very particular case, it would have been sorta okay to do the PR, but it’s just less mental juggling / overload / complexity if ALL PRs for that repo start here 
… that’s it!
2 Likes
So we need Jeremy to take a look and approve the PR being reopened, right? Does anybody have any objections to the PR in the meantime?
Changes to the docs typically are only reviewed and approved by Jeremy. It’s not in the maintainers’ repo so no one else is usually involved.
2 Likes
@iHiD , is it OK to run with this change (making the docs reflect what’s already implemented)? I guess the filter addition @Meatball mentioned would apply to a different repo anyway — we could open an issue there and at least the docs part is done?
Or if it’s OK by you I can make the addition at website/app/models/track.rb at 8cde63751dbf27cf9affa65d15a70043cd3aa199 · exercism/website · GitHub as well, then I guess the implementation is complete.