February 8, 2023, 11:10pm
I’m looking for a “review buddy” to help
@georgyo as he gives the track a lick of paint. Any experienced Exercism maintainers know enough Ocaml to help out wave things through?
See Update opam libraries: Add core, ounit2, ppx_deriving - #7 by iHiD for context
I’m not a maintainer but if I can help, I’m up for it.
February 9, 2023, 12:34pm
@tautologico. Your PRs would be welcome too!
But we really need someone experienced (with Exercism) to help with the reviewing process as well
I’m not going to be able to sanity check syntax, but I could review text and “exercism structure”, if that helps.
February 9, 2023, 7:11pm
That would be great. Thank you!
@georgyo @tautologico - please tag @BethanyG in any of your PRs that you’d like checking over from an Exercism perspective (or generally waving through!)
@iHiD - Just saw Update test runner to version 2 by georgyo · Pull Request #35 · exercism/ocaml-test-runner · GitHub fly past (and part of it is in python), but cannot reopen it on the repo. Would it be possible to either add me, or add the reviewers group? many thanks!
February 10, 2023, 12:19am
@georgyo You need to accept the org invite I sent you.
February 13, 2023, 2:00pm
@iHiD I accepted the invite on Friday, but my PRs are still getting autoclosed.
Batch of PRs from the weekend:
The test-runner-changes that got merged on Friday unfortunally had a bug where the docker entrypoint was still set to
run.sh instead of the new
run.py. Part of this was due to the fact that run-tests-in-docker.sh did not mimic how tests were actually being executed on production. This PR hopefully makes the test match more closely.
04:26AM - 11 Feb 23 UTC
Make the docker entrypoint run.py
Fix `run-tests-in-docker.sh` to match how t
… ests are run on production.
Fix sanitation of output
Make json output human readable for better results diffing.
Similar to the above, testing in the exercises repository did not mimic the production environment for tests. Now it can.
09:29PM - 12 Feb 23 UTC
When testing changes there was no ability to see how these changes would actuall
… y be tested by the `ocaml-test-runner` image.
A side effect of that is might be difficult to know if a change will actually be able to be tested once deployed. It was also difficult to make changes to the test runner and know if all existing problems will test as expected, resulting in broken exercises.
Hopefully this will help prevent future issues like this one: https://github.com/exercism/ocaml-test-runner/pull/37
This PR also uses some slightly more advanced Make features than the rest of the file. Specifically so you can you can pass `-j` to make. I was going to modify the `test` and `clean` but I don't know if that is desirable by the community.
Finish the migration of oUnit → ounit2
09:39PM - 12 Feb 23 UTC
The rest of the migrating to ounit2
Roll the allergies qcheck tests into ounit2.
09:50PM - 12 Feb 23 UTC
Formatting differences come from test_gen
This one is more opinionated than the others. I had trouble with the system dependency of
bmake for getopts. This does a fair amount of standardization in that project.
02:00AM - 13 Feb 23 UTC
This started because getopts has a rather unusal system dependency of bmake. bma
… ke, at least on Archlinux, requires fiddling with the MAKESYSPATH environment variable to work.
While working there, there was several code base inconsistencies and subtle bugs. Such as creating directories with permission 640 meanining that directories it created could not be accessed by the user that crated them.
All the commands had incorrect help text on that arguments they took as well, making it even more difficult to use.
There are still a bunch of stubs, but hopefully a more consistent codebase will make it easier for people to contribute.
My next wave is going to be updating the
problem-specifications submodule. It would have been in this wave, but
forth both have added some irregular tests that I haven’t figured out how to deal with yet.
I think you have to set org membership status to public.
February 13, 2023, 4:36pm
That’s because this isn’t merged:
Add custom token to community contributions workflow by kytrinyx · Pull Request #454 · exercism/ocaml · GitHub
@ErikSchierboom @kytrinyx Can we force-merge this everywhere now pls?
February 15, 2023, 4:46pm
Just finished getting in all the PRs for everything that was on my hit list of improvements.
There are 7 PRs from me there, and they all should apply cleanly on top of each other.
I’ll gladly take any comments from anyone interested. Though I’ll have limited internet the next two weeks while I am traveling. So no rush on any of this.
February 17, 2023, 4:36pm
Wonderful. Thanks so much