[bank-account] potential BUG

[andrerfcsantos]

I removed the flag from this exercise and from anecdotal testing on a few submissions, I’m not getting any timeouts. Tested on solutions that pass the tests, fail the tests and don’t even compile. I got the expected results from all those scenarios relatively quickly.

So I guess the issue is solved.

I’ll still dedicate some time to investigate if there’s a way we can viably re-introduce this flag.

[SleeplessByte]

@andrerfcsantos

For instance, the program @jfgobin posted here doesn’t even compile because the variable balance is declared and not used, and the test runner does try to compile the program before running the tests. So, if the problem was just the runtime, this should be a fail-fast situation for the test runner. But it isn’t. I was able to confirm this by building and running the test runner image locally. It took ~8 seconds to run the tests regardless of whether the program failed to compile or could run all the tests and pass. Disabling the -race flag, made the tests run in ~2 seconds. This means the -race flag is slowing down the tests by ~4x!

FWIW on TS I have flags in the config.json for the exercise that turn features on-or-off in the test-runner.

You may want to do the same?

[andrerfcsantos]

We are doing the same actually. That’s how this flag was enabled for this exercise, and now disabled.