Reviewed, approved, and merged! Thank you for submitting this @petrem.
Gotta go back and review my solution now. I think I did an attr creation in my __init__, so I am doing work every time an object is instantiated. oops.
Would welcome typo patrols from you and @colinleach - should either of you care to take that on! My spelling is terrible, and I am (purportedly) a native speaker. One wonders.
What I meant was NOT that someone with good English doesn’t do typos. I meant that I should be able to spot many such typos and make sense of the phrasing, and so on, so that it wouldn’t be inappropriate for me to take that on.
Book publishers have (or had) people just hunting for typos (ok, and grammar issues), so they are correcting after the most proficient language users out there… I wont be ashamad for my typoing sir!
Sorry @colinleach, while I agree typos can and do breed in the dark, someone has to have created the first two (per realm of existence), to start with. They aren’t lice, after all.
I … don’t know if that tracks. Abiogenesis feels like it applies to some of my writing. There are many things that I swear I spell-checked that end up with typos anyway. I’m so good at them that I often flummox the checker and it can’t come up with a suggestion!
But perhaps they migrate to find partners, or are a contaminate from my fingertips…
I did once have a teacher ask in wonder if I was “trying” to prove a point with my spelling test scores - they just couldn’t figure out why someone with my level of comprehension could be so stupid with the words.
I finally finished a project and will have some free time.
For me it would be helpful to read through the approaches on the Python track and do a typos patrol, along with other minor checks and fixes, should there be anything that stands out.
Please let me know if that’s OK with you, and whether I should do separate a pull request per exercise or one PR to rule them all (or some other way).
If there’s any simple housekeeping that needs doing and makes sense to be done at the same time, please let me know.
@colinleach please let me know if you’d like to do some of them, or perhaps double-check after I’m done?
I’d be delighted if you wanted to do an approaches audit.
The easiest for me would be 1 PR per exercise, especially if you’re going to review syntax and grammar as well as typos (doing just typos is just fine - so don’t feel obligated!). Easier to have a discussion in GH, and easier to “check off the list”, once we’ve reviewed
I think it can feel a little overwhelming at first. Each completed set of approaches is in the .approaches folder under each exercise. So, for example, the approaches for wordy are under https://github.com/exercism/python/tree/main/exercises/practice/wordy/.approaches
Each .approaches should have a config.json and a introduction.md (which outline all the available approaches for an exercise). Then there will be 2 or more subfolders that include the approach in detail, along with a code snippet. Be careful of the snippets: they are sharply limited in length, so aren’t necessarily complete nor “Python formatted” with extra whitespace (since that counts as a line). For more info on approaches, see the approaches section in the Building Exercism docs.
See the table below for which exercises have completed approaches and which are “in progress” (which have an unmerged PR). Hopefully, I didn’t miss any.
Given all the other things I have been totally failing to do recently, it would be dishonest to pretend that I can make much of a useful contribution to this, any time soon. Sorry!
Like @BethanyG, I would be delighted for you to get started on this. Good luck!
a big thread tagged for building exercism and python with name talking about clean up approaches would be ideal imo
if it is mostly involved a handful of familiar people and has potential to be a long ongoing process then a single thread (for that specific track) imo is better than creating a bunch of smaller threads for each exercise
@petrem - IMHO, unless you are considering doing this for approaches across multiple language tracks, the best place for a “cleanup” thread for approaches would be in the language track you are doing the audit for.
So that would be either Programming >> Python or Building Exercism >> Python.
Up to you though. It is also appropriate for Mentoring Chat >> python, since approaches and mentoring notes are involved. I do agree that this particular thread probably needs to be closed, and a new one that states the audit purpose (maybe with a tracking list) should be opened. Would you like me to do that for you?
Conversely, since we’ve agreed on this work, and you have done several PRs and now have a feel for it, a forum discussion thread may not be the best route. It may be less “noisy” to do a tracking issue in GH and do the discussions there in the PRs and issues - so I am quite happy to do that as well.
As for Wordy - I wrote that one. My the universe have mercy on your soul
Let the record show that the defendant finds the copy to be illuminating the mind and enriching the spirit ; has the highest regard to the Author, who is brilliant and adequate in every way ; and asks “oh paahhleeeezzz be lenient”.