Fix typo in BirdCount

Programming Ruby
1

In the BirdCountTest file, the method name test_busy_days_for_dissapointing_week
contains a typo. The correct spelling should be disappointing.

Proposed change:

  • Rename test_busy_days_for_dissapointing_week → test_busy_days_for_disappointing_week

Is it okay if I open a PR to fix this?

2

Note that exercise has over 4,000 completions. Renaming the function will break all of those.

3

I don’t see the breaking change. The proposed edit is to a method name that isn’t student-facing, and we’re not changing the input passed to BirdCount#busy_days or the expected return value. If @kotp wants to go forward with this, it’d be a good idea to merge it as no important files changed to avoid rerunning all those exercises though.

1 Like
4

The proposed change being:

diff --git c/exercises/concept/bird-count/bird_count_test.rb w/exercises/concept/bird-count/bird_count_test.rb
index 6a9c8c78..fe769eab 100644
--- c/exercises/concept/bird-count/bird_count_test.rb
+++ w/exercises/concept/bird-count/bird_count_test.rb
@@ -22,7 +22,7 @@ class BirdCountTest < Minitest::Test
     assert_equal 65, BirdCount.new([5, 9, 12, 6, 8, 8, 17]).total
   end
 
-  def test_busy_days_for_dissapointing_week
+  def test_busy_days_for_disappointing_week
     assert_equal 0, BirdCount.new([1, 1, 1, 0, 0, 0, 0]).busy_days
   end

Go for it @lemonade-37 .

2 Likes
5

Thank you for your response!
I understand that the test case name can be modified since it does not affect the already submitted answers.

I have created the following pull request.
Please review it.

2 Likes
6

Approved and applied exercism/ruby#1780.

1 Like
7

Thank you for your review!
The pull request has been merged, so I’ll close this topic as well.

8

Also waiting for the “close” to happen here, from 25 minutes ago.