[Poetry Club Door Policy] exemplar solution improvement

Programming JavaScript
,
21

You can hand edit the file or just install Prettier locally and use that tool for format the file.

22

On our repo we can run an auto format. Let me do that.

2 Likes
23

Thanks! I did a “Trigger builds” commit and now the workflows are pending approval.

1 Like
24

I’ve marked the pull request as ready for review now.

1 Like
25

Reviewed & Approved. Few nit-picks left you can fix and then we can merge.

26

Thanks! I accepted most of the suggestions and took a look at the style guide. Regarding linking .at() to MDN, I didn’t put the link there because I had it in the introduction, where it was first mentioned. Would it be better to add the link there because it’s a while after the intro or keep only one instance of the link?

1 Like
27

Nah, it’s fine. I’ll re-format, re-start the checks and then merge!

1 Like
28

Great stuff! Thank you for this contribution. If you encounter more that could use some content, open a topic and ping. We’re eager to get approaches in.

1 Like
29

Aaaaand it’s up.

You should also have received reputation.

30

It sure is neat to see what I wrote myself being there. And yeah, if I have the time and I see another that could use more content, I’ll be happy to help! (And 24 rep, nice!)

2 Likes