Proposing changes to one of the Kotlin Practices

Programming Kotlin
21

@SleeplessByte
And here is the second batch:

This one has a few other changes too:

1 Like
22

Sweet.

Please ping me profusely if I have not looked at these by Sunday night.

1 Like
23

They all look great. Approved them, tagged them, and waiting on the CIs to merge them.

Thank you @DerSimeon ! Much appreciated.

1 Like
24

Hey! Thanks a lot for merging them.

However I noticed that a few PRs are still closed and were not reopened. Was this intended?

fix: Added @Ignore to the tests by DerSimeon · Pull Request #670 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #671 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #672 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #673 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #674 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #675 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #676 · exercism/kotlin
fix: Added @Ignore to the tests by DerSimeon · Pull Request #677 · exercism/kotlin

25

(I’ve reopened them so CI can run)

26

Thanks Monsieur iHid,

Mr. Byte would it be possible to also mark the for hacktoberfest? pretty please

1 Like
27

You already have 4 approved, so the extra ones are not going to give you something extra, but yes!

28

All merged

2 Likes