This hasn’t yet been approved by a member of exercism/guardians, eg myself. I reviewed it but I have open suggestions I’m waiting on before approving it.
3 Likes
No worries, we will help.
Are you okay with the proposed changes?
Better minds than mine have okayed it. Go!
1 Like
I think that I have incorporated all your suggestions within the scope of my PR. The style and best practice things should be treated separately. Note that the COBOL test runner at least have four shell scripts besides run.sh.
Thanks, Bruce.
Style/best practice of existing lines can be a separate PR. Any newly added lines should follow best practices, though. There’s still some pending changes on tests/example-premature-termination/test.sh that I would prefer be resolved to avoid adding tech debt to the repo.
OK. It’s done.
I think that introduced a bug. I left a suggestion to fix said bug.
Looks good to me! This now have exercism/guardian approval. @axtens as track maintainer, you should now be able to merge this.
2 Likes
Merged! Thanks to everyone concerned.
5 Likes
SOME TESTS WERE NOT PERFORMED. A PARAGRAPH BEING TESTED MUST HAVE FORCED THE PROGRAM EXECUTION TO TERMINATE (E.G. USING STOP RUN, GOBACK, ETC.)
That’s sufficient. Mind you, it leaves it to the student to put two and two together and take out the STOP RUN or GOBACK or whatever could go in the ETC slot. But we can leave that till someone grizzles about not being spoon fed.
1 Like
Sweet stuff. Thanks @Borderite and @axtens (and @IsaacG and everyone else who chimed in of course).
1 Like