I haven’t been following the discussion, but just in case it’s helpful, here’s the past PR that updated the instructions
Thanks, good point. I see "property": "proteins" should probably also be fixed in the canonical data too, but since we were avoiding changes to that for “stop codon,” I’m not sure. @BNAndras ?
I’m not sure about how changes to properties might play out, but I think we should avoid updating the canonical data if possible and focus on the instructions.
2 Likes
What @BNAndras said. Updating the properties may mean reimplementing all the tests, which seems like a lot.
2 Likes
OK, given that, is everyone OK if I PR based on my summary above? Tweak language and formatting in `protein-translation/description.md` - #20 by codingthat
I think you should mention that stop codons exist before explaining what to do when encountering them.
Good catch, my bad.
Also my link wasn’t the best, I meant Tweak language and formatting in `protein-translation/description.md` - #16 by codingthat plus whatever supersedes it in Tweak language and formatting in `protein-translation/description.md` - #20 by codingthat .
Seems reasonable to me. Something like this?
- RNA: `"AUGUUUUCU"` => translates to
- Codons: `"AUG", "UUU", "UCU"`
- => which become a protein with the following sequence =>
- Protein: `"Methionine", "Phenylalanine", "Serine"`
+ RNA `"AUGUUUUCU"` translates to codons `"AUG", "UUU", "UCU"`.
+ That become a protein with the sequence `"Methionine", "Phenylalanine", "Serine"`.
- All subsequent codons after are ignored, like this:
- RNA: `"AUGUUUUCUUAAAUG"` =>
- Codons: `"AUG", "UUU", "UCU", "UAA", "AUG"` =>
- Protein: `"Methionine", "Phenylalanine", "Serine"`
+ All subsequent codons are ignored.
+ For example, RNA `"AUGUUUUCUUAAAUG"` translates to codons `"AUG", "UUU", "UCU".
+ That become a protein with the sequence `"Methionine", "Phenylalanine", "Serine"`.
1 Like
I was thinking a table would be more readable: Tweak language and formatting in `protein-translation/description.md` - #20 by codingthat What do you think?
Got it. That looks good to me.
1 Like
Cool. Time to PR? Any objections?
1 Like
Asking for a negative is hard 
Maybe ask for a go ahead and wait for 3 maintainers to agree.
A PR with those changes sounds good to me. Anyone else?
1 Like
I’m in favor of proceeding.
1 Like
Let’s proceed 
1 Like
Updated Tweak language and formatting in `protein-translation/description.md` by codingthat · Pull Request #2558 · exercism/problem-specifications · GitHub . You’re welcome @mk-mxp . Thanks for your help, everyone!
1 Like
Just circling back to double check at @IsaacG 's request. Is this OK for the final format and wording of the changed part?
You can break an RNA strand into three-nucleotide sequences called codons and then translate them into amino acids to make a protein like so:
| RNA | Three-letter codons | Amino acids |
|---|---|---|
| “AUGUUUUCU” | “AUG”, “UUU”, “UCU” | “Methionine”, “Phenylalanine”, “Serine” |
There are also three STOP codons. If you encounter any of these codons, ignore the rest of the sequence — the protein is complete. For example, UAA is a STOP codon, so ignore any subsequent codons:
| RNA | Three-letter codons | Amino acids |
|---|---|---|
| “AUGUUUUCUUAAAUG” | “AUG”, “UUU”, “UCU”, “UAA”, “AUG” | “Methionine”, “Phenylalanine”, “Serine” |
(Note that the latter AUG is not translated into another methionine.)
Below are the codons and resulting amino acids needed for the exercise.
Are you only rewording the mentioned sentences here or also removing content which isn’t mentioned in this post? If you are dropping content, please mention explicitly which parts are being removed.
It’s not clear from the post, but the prior version did not have parentheses around the note. It would be helpful to call out what you are changing here.
Are the parenthesis around the Note needed? I don’t think that is consistent with notes in other exercises.
It did: Tweak language and formatting in `protein-translation/description.md` - #20 by codingthat The first post just now erroneously had the "Note: " version because I copied from a local preview of the change we discussed on GitHub. Please ignore that edit, this bracketed version is actually what I originally proposed, as you can see from the link.