Wishlist: array language like K

Exercism Bugs & Feature Requests
41

Where do I see those in the PR?

42

I did not change them now. I just want to know if there is something to do with before lauch.

43

The LICENSE is the right one. As for the Makefile, I don’t know if it is used :man_shrugging:

1 Like
44
  • Add files to the github action for testing
  • Correct tests behaviour when an atom is expected and the solution returns empty

@ErikSchierboom
I could not make the github action for test works properly, Could you please review it and see if I’ve made any mistakes?

45

@andradefr8 The test script was missing the executable bit. I’ve fixed it in: GitHub Actions Testing Files and Bug Fixes by eNascimento178 · Pull Request #97 · exercism/j · GitHub

46

Other than that, nice work! I’ve approved

1 Like
47

I believe that with this PR i completed all steps listed here necessary for lauch.
If there is something else, let me know.

I’ve made this post to try get other reviews about.

1 Like
48
49

In this PR, I’ve get to 40 implemented exercises from the 48in24 event.

I believe the track is ready to go live on the site. @ErikSchierboom @iHiD, do you have any feedback or is there anything that should be addressed before the launch?

1 Like
50

I’ve done a deep dive and it definitely looks ready! There’s a couple of things you might want to check off before launching:

  1. No code run for passing tests

When a test fails, I get the code run part (which is really nice!)

image
image788×457 15.1 KB

When a test passes though, I get this:

image
image777×306 8.5 KB

I assume this is the message field being populated? If so, that field is one really used for error messages. Could you also show the code run bit for passing tests?

  1. Update the average run time of the test runner

The track’s config.json has this section:

"test_runner": {
  "average_run_time": 20
}

However, the test runner is incredibly fast and seems to finish almost instantaneously. Maybe set this value to 2?

  1. Add warning for jconsole conflict

The installation page (https://exercism.org/docs/tracks/j/installation) could maybe add a section how jconsole could potentially conflict with the Java Console, which uses the same name. This might be confusing to students. I would suggest to put this in an exercism/caution block (see Markdown Specification | Exercism's Docs).

  1. Running tests from console
    Is there a way to run the tests from the command-line without start a jconsole? If so, you probably want to document this in the docs/TESTS.md and exercises/shared/.docs/tests.md files. Additionally, you’d want to add support for J in the exercism CLI: cli/workspace/test_configurations.go at 753a4eb927d8602c785d09a82068237762f66f76 · exercism/cli · GitHub

  2. Configure lines of code counter
    See Lines of Code Counter | Exercism's Docs
    As J is not yet supported by the tokei tool which
    we use to count lines, you’d need to add an entry for J to our fork: tokei/languages.json at master · exercism/tokei · GitHub

  3. Configure snippet extractor
    See Snippet Extractor | Exercism's Docs

  4. Tweak docs/ABOUT.md
    The about document starts with “J is a strange language”. I feel like as a student, this might not entice me to join the track Maybe this should be something like “J is an unusual language” or something like that?

1 Like
51

This PR solves point 01. I’ll work on the others tomorrow.

52

One tiny comment on that PR.

53
54

All points are done and merged!

55

Currently the test generator will format all tests as verbs where:

  • single input will become a monad
  • two input values produces a dyad where the first json argument is the right argument of the verb
  • any other situation become a monad with a list of boxes