8th Food-chain exercise is broken

Programming 8th
1

It’s not producing enough lines. https://github.com/exercism/8th/actions/runs/8993728337/job/24706011851#step:6:53

So how did it pass CI in the PR? The exercise was not tested.
https://github.com/exercism/8th/actions/runs/8987808552/job/24687186139

Looks like a bug here in the workflow: branch main is being tested for pull requests.
https://github.com/exercism/8th/blob/4add41d355e035df161036985d54ec78c490b06b/.github/workflows/test.yml#L7

@ErikSchierboom would you agree?

2

Ah, that was my fix for PRs from forks not working. I’ll revert it.

1 Like
3

Reverted in Run tests on pull request by ErikSchierboom · Pull Request #176 · exercism/8th · GitHub. And food-chain does indeed fail.

4

@glennj @axtens What’s weird is that when I run things manually in an 8th repl, I do get the correct results. Do you have any ideas why that might be the case? I also don’t see anything wrong with the stack after invoking the word.

5

I’ll look at it when I get time. In the meantime, is there a way to hide the exercise without reverting the PR?

6

To confirm, 8th development should happen in feature branches in the 8th repo, not from forks?

7

Yes: Skip food chain in CI by ErikSchierboom · Pull Request #179 · exercism/8th · GitHub

8

Correct! Otherwise CI will fail.