A doubt about log exercise

davecaos · February 24, 2023, 9:46pm

Hello folks!
I want to check something , I think maybe I misunderstood the exercise, because the tests cases don’t behave in the way I expected

The second exercise item ( 2. Send an alert) say something like:

If the log label is error or fatal , send the alert to the ops team.

No matter if it’s legacy or not

But for the “fatal” case is checked at “unknown code sends alert to dev team 1 for a legacy app” test case instead of been check at “fatal code sends alert to ops” test case

As far as i understood, this assert is wrong, it checks fatal level and return dev1

assert LogLevel.alert_recipient(5, true) == :dev1

And It should be added this assert at “fatal code sends alert to ops”

assert LogLevel.alert_recipient(5, true) == :ops

But I no really sure

github.com

exercism/elixir/blob/main/exercises/concept/log-level/test/log_level_test.exs#L56


      
          
            @tag task_id: 1
            test "level -1 has label unknown" do
              assert LogLevel.to_label(-1, false) == :unknown
              assert LogLevel.to_label(-1, true) == :unknown
            end
          end
          
          describe "LogLevel.alert_recipient/2" do
            @tag task_id: 2
            test "fatal code sends alert to ops" do
              assert LogLevel.alert_recipient(5, false) == :ops
            end
          
            @tag task_id: 2
            test "error code sends alert to ops" do
              assert LogLevel.alert_recipient(4, false) == :ops
              assert LogLevel.alert_recipient(4, true) == :ops
            end
          
            @tag task_id: 2

Thanks

andrerfcsantos · February 24, 2023, 10:01pm

Welcome to the forum!

This test is correct, and it should return :dev1.

level=5 and legacy=true => :unknown, not :fatal.
level=5 is only :fatal if it doesn’t come from a legacy app (check table on the instructions)

davecaos · February 24, 2023, 10:59pm

Hi Andre! Thanks for the welcome
You are right, it was my bad, I was using the integer log value instead instead of using the label (atom) from LogLevel.to_label/2 function

Thanks a lot !