[Bob] CoffeeScript Incorrect Test

Exercism Bugs & Feature Requests
1

In the CoffeeScript Bob exercise, test 6, “forceful questions”, checks this:

result = bob.hey 'WHAT THE HELL WERE YOU THINKING?'
expect(result).toEqual 'Whoa, chill out!'

According to the instructions, questions that are yelled should “Calm down, I know what I’m doing!”

For example, the JS equivalent test is:

const result = hey('WHAT THE HELL WERE YOU THINKING?');
expect(result).toEqual("Calm down, I know what I'm doing!");

The PR to fix the test.

If this is accepted, we can update the example solution.

2

Update: my bad, this is more complicated than I originally thought.

All the current solutions, 337 of which are published, follow these tests. Updating the tests would invalidate all of them.

Might it be simpler to change the instructions alone?

3

If the tests get updated, they should be updated to adopt what is in the problem specs. New versions of tests should match the spec unless there is a really good reason why they shouldn’t.

4

You mean we should maintain the same question?

This is the problem specs test:

{
  "uuid": "a5193c61-4a92-4f68-93e2-f554eb385ec6",
  "description": "forceful question",
  "property": "response",
  "input": {
    "heyBob": "WHAT'S GOING ON?"
  },
  "expected": "Calm down, I know what I'm doing!"
}

However, my question is, should we update the tests or the would it be easier to update the instructions? As far as I know, we use .append to modify problem-specifications exercise instructions. But in this case, we have to cut out this line.

5

I would go with updating the tests to match the problem specs, even if that means breaking existing solutions. However, I’m not a maintainer on this track.

6

I would do the same.

1 Like
7

Could you open the PR? I’ve pushed the commit modifying the example solution, but perhaps it needs to be reopened for the new commit to show up on the PR.

I’m not sure who the CoffeeScript maintainer is. Most of the recent PRs seems to be merged by Erik.

8

It’s currently unmaintained.

9

I’ve reopened

1 Like
10

That link gives me a 404 error. Is it perhaps available only to mentors maintainers?

1 Like
11

That link is only available to maintainers.

12

My bad, I had assumed you were a Python maintainer since you’ve been pretty active there. For what it’s worth, these are the launched but now-unmaintained tracks I see using PyGithub.

  • CFML
  • CoffeeScript
  • D
  • Groovy
  • LFE
  • MIPS
  • Objective-C
  • PL/SQL
1 Like
13

There was an unterminated string in the fixed test case. I created a PR for this little fix:

1 Like
14

@ladokp could you relay the error message you encountered for you to find this out?

15

@safwansamsudeen I didn’t save the error message and since the error is fixed now and the tests run smoothly again it’s difficult to reproduce the error message. I’ll try to reproduce it, but basically the test run threw an error regarding an untermitated string and pointed to the line of the “forced question” test.

16

The error was like this:

error: missing '
result = bob.hey 'WHAT'S GOING ON?'
                                  ^
1 Like