Bob: Request to add test case for shouting statement with question mark not at end

Exercism Support
1

The previous test cases would consider any shouting statement with a question mark to be a shouting question. This is not the case as a question must end with a question mark. This test case covers this scenario.

Opened PR #2661 and was directed here so hope you can help!

2

Which test?

Do you mean something like this?

3
1 Like
4

Thanks for getting back IsaacG, this would work given the user is not ā€œshoutingā€ (all caps) in this case.

Given the test case I gave of DO LIONS EAT PEOPLE? AHHHHH.
The sentence does not end with a question mark but is still shouting. Therefore should output Whoa, chill out! because it is not a question.
But given the current test cases there is no way to ensure that will happen when all CAPS. This is some example code I mentored earlier where I noticed this passing.

...
    if "?" in hey_bob and hey_bob.isupper():
        return "Calm down, I know what I'm doing!"
    if hey_bob.isupper():
        return "Whoa, chill out!"
...

This should fail as it would respond with Calm down, I know what I'm doing!. In reality this code passed all current test cases, my proposed test case should prevent this.

Thanks
Jack

1 Like
5

Iā€™m in favour. Iā€™ve seen people doing different regexes for each condition, and this is capturing an edge case.

2 Likes
6

Also in favor.

2 Likes
7

Iā€™m also in favor. Thatā€™s the usual three maintainers approving that we like to do before an problem-specs PR is welcomed. I think we can reopen the PR if there arenā€™t any objections.

1 Like
8

PR reopened. Thanks!

Next time please do discuss it on the forum first, though ;)

2 Likes
9

PR merged. I opened a follow up to sort the test cases.

1 Like