Hey,
As mentioned here:
opened 04:23PM - 24 Mar 25 UTC
closed 04:23PM - 24 Mar 25 UTC
Hey! This is my first issue and potentially my first PR (if I’m allowed to contr… ibute 😄).
In the [instructions for the grade-school exercise](https://github.com/exercism/cpp/blob/32fe0dae02765d426e389217e0d215abe00e168f/exercises/practice/grade-school/.docs/instructions.md?plain=1#L20-L21), it is stated that:
https://github.com/exercism/cpp/blob/32fe0dae02765d426e389217e0d215abe00e168f/exercises/practice/grade-school/.docs/instructions.md?plain=1#L20-L21
> "In fact, when a test attempts to add the same student more than once, your implementation should indicate that this is incorrect."
However, there are currently no tests that enforce this behavior.
I see two options:
1. Remove the instruction about duplicates, since it’s not being tested.
2. Add test cases to enforce the behavior, such as:
Preventing the same student from being added multiple times to the same grade
Preventing the same student from being added multiple times to the entire roster (if that’s the intended rule)
I've already implemented both test cases locally and would be happy to submit a PR. I just want to clarify which approach the maintainers prefer: removing the instruction or adding the tests?
Thanks in advance,
Marcel
There are either missing test cases or the last part of the instruction is misleading of the exercise “grade-school” of the cpp track.
(I did the exercise just now, that’s how I found it)
Yeah, that exercise’s test suite hasn’t been synced in a while with the upstream problem-specifications repo all Exercism tracks use. There’s an open issue at Update test cases · Issue #775 · exercism/cpp · GitHub tracking which exercises need to be updated including this one.
1 Like
Alright, thank you for the quick response!