Error Running Tests for Acronym

Programming OCaml
1

Hi there. I ran into an error trying to run the tests for Acronym on the OCaml track:

File "dune", line 5, characters 0-76:
5 | (alias
6 |   (name    runtest)
7 |   (deps    (:x test.exe))
8 |   (action  (run %{x})))
Fatal error: exception Not_found
make: *** [Makefile:4: test] Error 1

I nuked the folder, re-downloaded the exercise, and tried again, got the same issue. Then I copied my code into the web editor and got the same thing.

If I run dune build, nothing changes and I still get the same error when running make.

Strangely, if I remove the ‘-’ from the list of punctuation in my code, it will run the tests. What’s going on here?

My code:

let acronym words =
  let punct = ['!'; '_'; '-'; '.'; ','; '@'; '#'; '$'; '['; ']'; '{'; '*'; '&'; '%'; '^'; ';'; '('; ')' ] in
  let word_list = String.split_on_char ' ' words in
  word_list |> List.map (fun w -> List.init (String.length w) (String.get w) |> List.find (fun c -> List.mem c punct |> Bool.not) |> Char.uppercase_ascii) |> List.to_seq |> String.of_seq

Actually, the error came back after changing my code to this and attempting to test:

let acronym words =
  let words_no_hyphen = String.split_on_char '-' words |> List.fold_left (^) "" in    
  let punct = ['!'; '_'; '.'; ','; '@'; '#'; '$'; '['; ']'; '{'; '*'; '&'; '%'; '^'; ';'; '('; ')' ] in
  let word_list = String.split_on_char ' ' words_no_hyphen in
  word_list |> List.map (fun w -> List.init (String.length w) (String.get w) |> List.find (fun c -> List.mem c punct |> Bool.not) |> Char.uppercase_ascii) |> List.to_seq |> String.of_seq
2

The error is probably coming from your usage of List.find. Its documentation says it can raise a Not_found exception. Can you see why this might happen?

3

Thanks for pointing this out! I didn’t know exceptions could look this way in OCaml but now it makes sense that it would fail that way when running the tests.

1 Like