[expenses] Proposing a few fixes

[rahulrao0209]

Hey there folks!

Highlighting a few things that could be improved in the expenses Go exercise.

1. The test case error message in the following lines could be updated to use the correct function signature. The function signature in the code has DaysPeriod as the second argument & category as the third. In these lines however its flipped.

2. Test case only uses “unknown category” in the error message. Could this be updated to include the category in the message like it is shown in the instructions?
   

   

3. In line 3 (& 143) expense records seems to be the correct wording rather than expenses records. Not sure if this needs to change.

Happy to create a PR if any or all of these could be updated.

[IsaacG]

Go for it. If you’re touching markdown files, our markdown specs specify we want one sentence per line, which would be worth updating once the file is already being edited.

[rahulrao0209]

Okay, is there a preference for a single commit with a detailed commit message or multiple commits concerning the different parts of the proposed changes ?

[IsaacG]

Given that this is all minor doc improvements on one exercise, one PR is fine.

[rahulrao0209]

Okay here you go #2990

[IsaacG]

I left you feedback on the PR :) Thanks for opening the PR!

[rahulrao0209]

Thank you! All feedback’s been addressed. Happy to address any additional feedback.

[IsaacG]

PR merged! Thanks!