This issue was addressed in Exercism Forum for i18n broke.
Bug in every language > exercise > editor > feedback. I just corrected the pointer to the data, which should be rendered.
Change made was: whyGetFeedbackDescription replaced this variable/key with the correct one which is learningALanguage which can be located at /app/javascript/i18n/en/components-editor-FeedbackPanel.ts
I also made a PR as the Fix because it was a minor one. I hope it is open to outside contributors.
The core Exercism code is generally not open to unsolicited PRs.
1 Like
Whats in this case? Where only 1 word changed as the fix. Does this PR also considered as unsolicited?
Edited: The issue was reported before 22 days ago and didn’t saw an update on it. The issue was reported in i18n related topic.
Exercism’s policy for most repos is that unsolicited PRs are not accepted.
Any PR you open without being asked to do so is an unsolicited PR. The contents of the PR doesn’t change anything. The reporting history doesn’t change anything.
1 Like
Ok, Thanks for clarifying how contributions work. If you don’t mind me asking is it possible for me to work on the issue or not and whom should I get the approval from?
I have done 1 PR but it was asked me to do because I reported the issue. My question is does each repo has its own codeowners I should ask for approval or how does that work? Does the full contribution process from outside contributors have Documentations that I can checkout for better clarification?
Yes, each repo has its own set of maintainers. The maintainer list isn’t public.
exercism/website is part of the core Exercism product, maintained by the Exercism staff. Which effectively means just Jeremy. He’s the only one that touches that repo, by and large, and hasn’t been on the forum while he’s working on building/launching the new bootcamp.
The per-language/per-track repos like exercism/java or exercism/python are all run by maintainers that are volunteers. If you want to contribute to those, you should post on the forum first and see what the maintainers say.
For documentation, see the linked blogpost and the contribution guide.
2 Likes
Contributing doesn’t need to be complicated as long as you consistently post first on the forums. That way, we can discuss the issue, what needs to be done, and whether you should proceed.
1 Like
@IsaacG and @BNAndras Thank for the the explanation and being patient with me.
One last question, Can/Should I delete the PR branch if this PR is out of scope and will not be proceeded for Merging? Or is there a chance of PR getting merged?
It’s been closed automatically. No further action is needed.
1 Like