Fix StateOfTicTacToe tests

lapin · August 1, 2025, 5:31pm

There’s a typo in the tests, gamestate instead of gameState.

BNAndras · August 1, 2025, 6:00pm

The stub uses gameState, but the example and the test suite use gamestate (see below). Looking at similar exercises, I think gameState would be preferred. Changing the stub to gamestate is the conservative option here, but there are only 6 completions to date so changing the example and test suite for consistency’s sake won’t break a lot. It depends on what Erik wants to do.

github.com

exercism/fsharp/blob/4846ed31d8b1a183a1c8b4eb115ebec4fbced874/exercises/practice/state-of-tic-tac-toe/StateOfTicTacToe.fs#L6


      
          module StateOfTicTacToe
          
          // TODO: define the 'EndGameState' type
          // TODO: define the 'GameError' type
          
          let gameState board =
              failwith "Please implement the 'gameState' function"

vs.

github.com

exercism/fsharp/blob/4846ed31d8b1a183a1c8b4eb115ebec4fbced874/exercises/practice/state-of-tic-tac-toe/StateOfTicTacToeTests.fs#L15


      
          
          open StateOfTicTacToe
          
          [<Fact>]
          let ``Finished game where X won via left column victory`` () =
              let board = 
                  array2D [ ['X'; 'O'; 'O'];
                            ['X'; ' '; ' '];
                            ['X'; ' '; ' '] ]
              let expected: Result<EndGameState, GameError> = Ok EndGameState.Win
              gamestate board |> should equal expected
          
          [<Fact(Skip = "Remove this Skip property to run this test")>]
          let ``Finished game where X won via middle column victory`` () =
              let board = 
                  array2D [ ['O'; 'X'; 'O'];
                            [' '; 'X'; ' '];
                            [' '; 'X'; ' '] ]
              let expected: Result<EndGameState, GameError> = Ok EndGameState.Win
              gamestate board |> should equal expected

lapin · August 1, 2025, 8:43pm

The PR is here if you want: Fix StateOfTicTacToe tests by Sprootch · Pull Request #1323 · exercism/fsharp · GitHub

BNAndras · August 1, 2025, 9:12pm

I’m not a F# maintainer, but Erik will take a look and get back to you.

lapin · August 4, 2025, 6:01pm

The PR has been accepted by Erik so I guess we can close this topic.