[grade-school] a student can't be in two different grades test

3aluw · July 28, 2023, 11:51am

I think the test means that a name can only be accepted in one grade and prevent duplicates. so typescript school.add('Aimee', 2) school.add('Aimee', 1) should prevent the second add while accepting the first one (because it is not a duplicate) . However the test expects an empty array : expect(school.grade(2)).toEqual([])
I think it is not a real use case to delete the first entry when a duplicate is being added. what do you think ?

tasx · July 28, 2023, 12:32pm

You are correct. This has been fixed in problem specifications uuid 6a03b61e-1211-4783-a3cc-fc7f773fba3f but the typescript tests have not been updated.

bugrasan · February 5, 2024, 3:53am

this seems still open…

github.com

exercism/typescript/blob/main/exercises/practice/grade-school/grade-school.test.ts

import { GradeSchool } from './grade-school'

describe('School', () => {
  let school: GradeSchool

  beforeEach(() => {
    school = new GradeSchool()
  })

  it('a new school has an empty roster', () => {
    expect(school.roster()).toEqual({})
  })

  xit('adding a student adds them to the roster for the given grade', () => {
    school.add('Aimee', 2)

    const expectedDb = { 2: ['Aimee'] }
    expect(school.roster()).toEqual(expectedDb)
  })

This file has been truncated. show original

line 92 should be
expect(school.grade(1)).toEqual([])
instead of
expect(school.grade(2)).toEqual([])

is the patch as simple as this? or are there more hidden implications?

tasx · February 5, 2024, 1:03pm

No it’s not. The tests should be in sync with the problem specs, and this probably means changes in a lot of places.

bugrasan · February 5, 2024, 2:39pm

@tasx i might have been way too optimistic :-(
is there a guide/doc for developers/supporters you could point me too to help out?
in previous exercises on TS track i believe i have experienced couple more of these oddities and would like to help.

IsaacG · February 5, 2024, 2:52pm

ruthlessfish · November 4, 2024, 4:09am

This is also an issue in the Javascript track.