Improve `grade-school` description

Hey everyone! I have been reading the grade-school description and thought it could use some love and a grammar check. Below are the proposed changes. The changes are purely stylistic and don’t alter the content of the description.

Given students’ names along with the grade that they are in, create a roster for the school.

In the end, you should be able to:

Add a student’s name to the roster for a grade:
“Add Jim to grade 2.”
“OK.”

Get a list of all students enrolled in a grade:
“Which students are in grade 2?”
“We’ve only got Jim just right now.”

Get a sorted list of all students in all grades. Grades should sort be sorted as 1, 2, 3, etc., and students within a grade should be sorted alphabetically by name.
“Who all is enrolled in school right now?”
“Let me think. We have Anna, Barb, and Charlie in grade 1, Alex, Peter, and Zoe in grade 2 and Jim in grade 5. So the answer is: Anna, Barb, Charlie, Alex, Peter, Zoe, and Jim.”

Note that all our students only have one name (It’s a small town, what do you want?) and each student cannot be added more than once to a grade or the roster. In fact, when If a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.

Here’s the list of proposed changes:

  1. “that they are in”“they are in”

    • Simplified to improve readability.
  2. “for a grade”“for a grade:”

    • Added a colon at the end of the line for consistency with list formatting.
  3. “just now”“right now”

    • Replaced “just now” with “right now” for clearer, more natural phrasing.
  4. “Grades should sort as 1, 2, 3, etc.”“Grades should be sorted as 1, 2, 3, etc.”

    • Added “be sorted” for correct grammatical structure.
  5. “Who all is enrolled in school right now?”“Who is enrolled in school right now?”

    • Removed “all,” which is unnecessary here, to improve clarity and grammar (This is the one that made me take a closer look at the whole description in the first place. I’m very open to alternative phrasing for this)
  6. “and Jim in grade 5. So the answer is: Anna, Barb, Charlie, Alex, Peter, Zoe and Jim”“and Jim in grade 5. So the answer is: Anna, Barb, Charlie, Alex, Peter, Zoe, and Jim.”

    • Added “and” before Jim in the list for correct punctuation, and added a period at the end.
  7. “added more than once to a grade or the roster”“added more than once to a grade or the roster.”

    • Added a period at the end for completeness.
  8. “In fact, when a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.”“If a test attempts to add the same student more than once, your implementation should indicate that this is incorrect.”

    • Replaced “when” with “if” for smoother and more conditional phrasing.

Let me know what you think about these changes!

Seems good to me!

1 Like

Looks good.

1 Like

@tasx, I just wanted to check if we’re waiting for any additional feedback before moving forward. If it helps, I’d be glad to raise the PR to implement these updates. Let me know if that works, or if there’s anything else I should keep in mind!

These are grammar and style fixes, with no objections so far. Since @Elahi-cs proposed the changes, we’ll let them handle the PR. If they’re not interested, they can let us know in this thread, and then you can take it over.

1 Like

Sure! I’ll wait for @Elahi-cs to let us know if they are interested in raising a PR.

@tasx It has been over a week, and @Elahi-cs has not shown any interest in raising the PR nor has there been any response from their side. Should we continue waiting for them, or would it be better for us to raise the PR ourselves?

@jagdishdrp Without a reply from them, we can’t be certain whether they’re interested. However, I’m assuming they are, given the effort they put into creating the thread.

It’s also possible they’re busy with other things, as they were last active on November 8.

@Elahi-cs, are you interested in raising the PR?

1 Like

@tasx You’re right, I may have been a bit too eager. I just wanted to make sure we don’t lose momentum, but I understand they might be busy.

@Elahi-cs, whenever you’re ready to raise the PR, just let us know! We’re happy to move forward when you’re available.

1 Like

Sorry everyone for the wait! As @tasx correctly assumed, I’m both interested in submitting the PR and was busy with other things. I’ll get on it!

EDIT: Here’s the PR!