Inconsistent naming JavaScript Enchantments

Programming JavaScript
1

This is really minor, but I think the JavaScript Elyse's Enchantments exercise should rename the function removeItemAtBottom → removeItemFromBottom. This makes it consistent with the comment:

Remove card from the beginning of the cards

as well as the removeItemFromTop function.

2

What would be the impact of changing the function name (on all the prior solutions)?

3

That is an important question. It has two obvious answers, each with drawbacks:

  1. Simply change the solution’s requirement by renaming. Legacy solutions all break. Considering that this is an entry-level exercise for a high volume track this should probably be avoided.
  2. Change the name but let the tests accept either the old or the new name. This is a maintenance headache and does not enforce use of the new name.

So considering how minor this issue is it may make sense to just leave it as is.

4

Yeah. I’m not the track maintainer for JavaScript, but I suspect that’s the likely decision here :wink:

See also Suggesting Exercise Improvements | Exercism's Docs