Issue In Mecha Munch Management / Phyton Instructions

[Tamarack-76]

First just wanted to say I think what you have built here is great and I like the environment and the development support. Found this while looking to learn Python in some spare time after years programming in other languages.

For the issue in the code we have the stub:

def add_item(current_cart, items_to_add):

but in the instructions for the exercise its

Create the function add_items(<current_cart>, <items_to_add>) that takes a cart dictionary and any list-like iterable of items to add as arguments. It should return a new/updated shopping cart dictionary for the user.

and:

add_items({‘Banana’: 3, ‘Apple’: 2, ‘Orange’: 1},
(‘Apple’, ‘Apple’, ‘Orange’, ‘Apple’, ‘Banana’))
{‘Banana’: 4, ‘Apple’: 5, ‘Orange’: 2}

add_items({‘Banana’: 3, ‘Apple’: 2, ‘Orange’: 1},
[‘Banana’, ‘Orange’, ‘Blueberries’, ‘Banana’])
{‘Banana’: 5, ‘Apple’: 2, ‘Orange’: 2, ‘Blueberries’: 1}

Suggest it should be add_items!

[siebenschlaefer]

Good catch!

Yes, in the Mecha Munch Management concept exercise the task #1 talks about a function named add_items (with an “s”) but the initial stub and the tests want the function add_item (without an “s”).

I believe the maintainers would accept a pull request if you want to fix the instructions.
Otherwise we would do that ourselves.
(@BethanyG Please correct me if I’m wrong.)

[BethanyG]

@siebenschlaefer @Tamarack-76

Nice catch! I’d be happy to accept a PR (just link it here when you are done). But let’s make sure to match the tests (so we don’t invalidate existing student solutions).

If I don’t hear from you, I’ll go ahead and fix it by EOD tomorrow (Sept. 17th)

[BethanyG]

Fixed and merged in PR 3774.

Please Note: Though this reads a little weird, I chose to not change the stub and test file function name because doing so would have invalidated over 2700 student solutions.