[Meltdown Mitigation/Conditionals Concept] Error in `just_the_buzz` Code Example

Here Conditionals in Python on Exercism is an error with the function just_the_buzz because

just_the_buzz(10)
'10'

returns "Buzz" instead of "10". Would change it to just_the_buzz(7).

1 Like

Yes, this is incorrect. You can create a PR for this one.

(cc @BethanyG this one is just in a doc, and doesn’t touch tests, etc.)

Thanks @SleeplessByte. One question, how do I know create a PR? I opened one today, but it was automatically closed due to some policy. I searched for some guidelines in the Python repo, but did not find instructions on that.

Hi @akmaekki7 :wave: ,

Thank you for your detailed eye, and for pointing out typos. :smile:
If you link to the PR fixing this typo, I will happily reopen and review it.

In general, the Python track is not accepting community contributions, which is stated in the README on the repo. This is why PRs are automatically closed.

Python occasionally accepts contributions if the issue is discussed on the forum first, but right now, we (I) don’t have the bandwidth for lots of PRs or much new contributor onboarding.

That might change in the future, but for now (while the Bootcamp is running and the current track infrastructure work is ongoing), the answer to “do I create a PR?” is no - unless invited to in a forum thread. :slightly_smiling_face:

1 Like

To add to what Bethany just said @akmaekki7 , because it is now accepted (see the first two lines in the post I am replying to) one of us will reopen the PR if you post a link to it here.

So to summarise:

  • some tracks do not accept contributions by default
  • exceptions are made on a case-by-case basis, always through the forum like now
  • a maintainer will reopen the PR and review / merge it
  • you will receive reputation for the work once merged

In general:

  • Open thread on the forum first
  • Link to the thread in the PR to make our life easier
  • Link to the PR in the thread to make our life easier

Thank you very much for wanting to help out!

3 Likes

Hi,
Created a tiny PR here: Fix example for just_the_buzz by akmaekki · Pull Request #3914 · exercism/python · GitHub

2 Likes

Reviewed, approved, and merged!

Thanks for spotting this, and for fixing it. :blue_heart: .

1 Like