Misinfo in Ruby concept exercise

pontabi · August 21, 2024, 3:38pm

I’m a new learner here, happy to find this great app and community😆

I found a tiny mistake in Ruby Exercise Document.

exercism/ruby/blob/6619a5c431d920ddb43658ebf7d352594f82f96a/exercises/concept/assembly-line/.docs/introduction.md?plain=1#L103-L107


      
          unless value < 2
            "1 is not greater than 2"
          end
          # => "1 is greater than 2"
          ```

# as-is
unless value < 2
  "1 is not greater than 2"
end
# => "1 is greater than 2"

# to-be
unless value < 2
  "1 is not greater than 2"
else
  "1 is greater than 2"
end
# => "1 is greater than 2"

It’s just a minor mistake, but I wanna fix this for my first PR if possible. May I?

iHiD · August 21, 2024, 3:58pm

Hey. Thanks!

Yes, I actually don’t want unless/else pair in this group at all. It’s not used in the exercise, so shouldn’t be here.

So you can delete this bit entirely:

unless value > 2
  "1 is not greater than 2"
end
# => "1 is not greater than 2"

Thanks

pontabi · August 21, 2024, 5:05pm

Yes, I actually don’t want unless/else pair in this group at all. It’s not used in the exercise, so shouldn’t be here.

In that sense, unless statement section should be remove as well?

github.com

exercism/ruby/blob/6619a5c431d920ddb43658ebf7d352594f82f96a/exercises/concept/assembly-line/.docs/introduction.md?plain=1#L72-L87


      
          ## Unless statement
          
          The `unless`unless statement works very similarly to the `if` statement but it will run the code inside the `unless` statement if the condition is falsey.
          
          ```ruby
          value = 1
          unless value == 1
            "1 is not equal to 1"
          end
          # => nil
          
          unless value > 2
            "1 is not greater than 2"
          end
          # => "1 is not greater than 2"
          ```

Or, only remove unless/else pair from Else statement section?

iHiD · August 21, 2024, 5:09pm

I’m ok with the unless section, but not the unless/else section - so remove that one. Thanks

kotp · August 21, 2024, 6:48pm

I have reopened and approved it.

If no one brings it in by the time I look at it in a few hours, I will do that then.

Thank you for doing the work and linking the conversation to the pull request!

kotp · August 21, 2024, 9:48pm

And to update exercism/ruby#1713 has been brought in.