In the Affice Cipher exercise, the testcase test_decode_with_a_not_coprime_to_m
tries to decode “Test” with a bad value of a.
This is two ValueErrors in one testcase, and should be split.
I have a fix here:
but you guys don’t accept PRs for some reason.
Hi @stasinos
Welcome to the Exercism forums!
Thanks for making a suggestion for the Affine Cipher exercise.
Affine Cipher
is a practice exercise that draws its problem description and test data from a common cross-track repository called problem specifications .
The exercise on the Python track is auto-generated from the problem specs repo, and does not change any data or test outcomes.
Suggestions for improving the exercise/test data, should be made under problem specifications, so that all tracks can benefit from the discussion and/or change. Any changes made to the Python track directly would be overwritten when the exercise was next synced.
We auto-close PRs submitted directly to the Python track and other content tracks for multiple reasons:
-
Newer contributors are unaware of problem specifications, and may also be unaware of other considerations when editing things like test files or problem descriptions.
-
The tracks team of maintainers may not be checking the repo frequently, so posting to the forum ensures that a wider swath of Exercism maintainers and staff will be able to see and respond to the PR or issue.
-
Students may or may not fully understand the language or purpose of the tests, and so might log a bug or change something that shouldn’t be changed. Having a discussion on the forum allows them (and other students, mentors, or maintainers) to clarify misunderstandings.
@iHiD (or other forum admins) – can we please move this to a problem-specs
discussion? Many thanks!