PHP Versions support?

tomasnorre · March 1, 2024, 7:48am

What are the plans for updating PHP Versions support?

PHP 8.3 have been out for a while, and I would love to have runners running with PHP 8.3, besides that I would suggest updating minimum requirement to PHP 8.1 as PHP 8.0 is EOL since end November 2023.

I would be happy to take on the task of updating the CI in the PHP track and the Runners for the tests, I don’t know if i have access to the repository though.

https://www.php.net/supported-versions.php

mk-mxp · March 3, 2024, 11:09am

This is the current plan:

github.com/exercism/php

Coordination: Upgrade to PHP 8.1 - 8.3 and PHPUnit 10

opened 07:54AM - 01 Mar 24 UTC

mk-mxp

This is what I think must be done: - [ ] Add PHP 8.3 to the CI of the track a…nd allow it to fail - [ ] Add PHPUnit 10 to the CI of the track and allow it to fail - [ ] Fix the problems that occur with PHP 8.3 and PHPUnit 10 - [ ] Prepare the [PHP test-runner](https://github.com/exercism/php-test-runner) to upgrade to PHP 8.3 / PHPUnit10 - [ ] Prepare the [PHP representer](https://github.com/exercism/php-representer) to upgrade to PHP 8.3 - [ ] Do the actual switch to PHP 8.1 - 8.3 and PHPUnit 10 as the production versions (including the test runner and representer) - [ ] Remove PHP 8.0 / PHPUnit 9 from CI - [ ] Update test generator to produce attributes not annotations - [ ] Convert tests from annotations to attributes. Use `rector/rector` for that. In the whole process, try to avoid re-running the representer and not to trigger re-testing all community solutions. These are very costly to Exercism.

I hope I have all that’s necessary in the correct order. If no-one is quicker than me, I will come to this as soon as I think I have a bigger timeslot for extra work

tomasnorre · March 3, 2024, 4:15pm

I think I can handle most of it, should it give it a spin the next days? I would split it up in multiple smaller PRs though to have them easier merged and reverse in case something is off.

I’m unsure about the test runners, not sure yet in which repository they live.

IsaacG · March 3, 2024, 4:17pm

mk-mxp · March 4, 2024, 8:43am

That’s why I wrote Coordination: in front of the issue title. There will be many different PRs over a longer period of time.

I also linked to the representer and test-runner repo, where work needs to be done, too.

I initially forgot to add student facing documentation…

tomasnorre · March 4, 2024, 9:16am

I have create a PR for the PHP Test Runner

tomasnorre · March 4, 2024, 9:24am

I overlooked the links to the repos. Thanks.