Resistor Color Duo should not silently ignore additional colors

dithpri · March 1, 2023, 3:17pm

Resistor Color Duo should not silently ignore additional colors

opened 03:11PM - 01 Mar 23 UTC

closed 03:11PM - 01 Mar 23 UTC

https://github.com/exercism/zig/blob/main/exercises/practice/resistor-color-duo/…test_resistor_color_duo.zig#L42-L47 This test expects the code to silently ignore any additional values in the input array. This pretty much goes against the Zig way of doing things, the hidden assumption can lead to bugs. ```sh $ zig zen * Communicate intent precisely. * Edge cases matter. * Favor reading code over writing code. * Only one obvious way to do things. * Runtime crashes are better than bugs. * Compile errors are better than runtime crashes. [...] ``` The function should return an error instead of silently continuing when the passed in slice is longer than 2 elements.

'nuff said

PS. This forum is confusing as hell, couldn’t find how to add the Zig tag.

ErikSchierboom · March 3, 2023, 8:57am

The zig category was missing, so we added it!