Scale Generator exercise in Kotlin track has wrong test cases

backdevjung · May 21, 2025, 7:32am

There are 17 cases, 2 are correct, and 15 are wrong

Please refer to JS track’s Scale Generator and correct the test cases accordingly.

Given length n of input, interval() should return length (n + 1) of output

All the test cases expects length n

IsaacG · May 21, 2025, 2:33pm

The scale generator exercise is deprecated and has been removed/marked inactivefrom most tracks.

BNAndras · May 21, 2025, 3:41pm

including JavaScript. If @SleeplessByte decides the exercise shouldn’t be deprecated for Kotlin, I was able to confirm that the track’s tests diverge on expected values from problem-specifications tests. Changing the expected values would break 258 completions to date.

github.com

exercism/problem-specifications/blob/main/exercises/scale-generator/canonical-data.json

{
  "exercise": "scale-generator",
  "cases": [
    {
      "comments": [
        "These tests have no interval.",
        "The chromatic scale is considered the default scale"
      ],
      "description": "Chromatic scales",
      "cases": [
        {
          "uuid": "10ea7b14-8a49-40be-ac55-7c62b55f9b47",
          "description": "Chromatic scale with sharps",
          "property": "chromatic",
          "input": {
            "tonic": "C"
          },
          "expected": ["C", "C#", "D", "D#", "E", "F", "F#", "G", "G#", "A", "A#", "B"]
        },
        {

This file has been truncated. show original

github.com

exercism/kotlin/blob/main/exercises/practice/scale-generator/src/test/kotlin/ScaleTest.kt

import kotlin.test.Ignore
import kotlin.test.asserter
import kotlin.test.Test

class ScaleTest {

    // Test chromatic scales
    @Test
    fun `chromatic scale with sharps`() {
        val expected = listOf("C", "C#", "D", "D#", "E", "F", "F#", "G", "G#", "A", "A#", "B")
        assertScalesEqual(expected, Scale("C").chromatic())
    }

    @Ignore
    @Test
    fun `chromatic scale with flats`() {
        val expected = listOf("F", "Gb", "G", "Ab", "A", "Bb", "B", "C", "Db", "D", "Eb", "E")
        assertScalesEqual(expected, Scale("F").chromatic())
    }

This file has been truncated. show original

SleeplessByte · May 21, 2025, 5:07pm

Whilst I personally like the idea of this exercise, I think we should follow suit and deprecate it from Kotlin. Anyone up for PRring it?

IsaacG · May 21, 2025, 5:13pm

Happy to do so. I’m not entirely sure why it didn’t get collected with the other PRs to deprecate this.

IsaacG · May 21, 2025, 5:24pm

SleeplessByte · May 21, 2025, 5:47pm

Thanks. Found your previous PR and that was the reason this wasn’t dealt with.

Thanks for raising this @backdevjung.

Merged!

IsaacG · May 21, 2025, 5:59pm

The tests are sad since they use an older Ubuntu LTS version.

Would you like a PR to bump that?

SleeplessByte · May 21, 2025, 11:35pm

That was already fixed!