I manually edited the files, and read them in case I could notice anything else by hand. The editor auto-formatted trailing spaces, which I couldn’t resist including in the commit
Would you mind reviewing and approving/merging if found acceptable?
I may raise a few more PRs for other projects, should I include them in this thread and tag the respective maintainers, instead of raising a new topic for each? It feels less spammy this way.
If we restrict the spellcheck edits to public-facing and track-specific docs (i.e. not the ones coming from the problem-specifications repo), I don’t see a problem in making PRs for Arturo, CFML, CoffeeScript, D, Emacs Lisp, LFE, Pyret, Racket, Red, or Vim script. There’s no need to create a separate forum thread for those. Just include the URL for this post in the PR in case I forget.
If you’re still doing Hacktoberfest, I can slap the label on one or two of the PRs to help you out.
Thanks a lot! I’ll take a look at those, in case there’s anything to fix
I’m not sure if they’ll qualify, but I wouldn’t mind the hacktoberfest label in case they do! I’ll raise the PRs regardless though, it’s an opportunity to check the open issues for anything that I may be able to handle.
@astyanax – Sorry, I can’t accept that PR. The trailing whitespace was purposeful. It is needed for proper formatting. Please remove those corrections. I will scan for the other spelling errors, but in general I would prefer that you do NOT submit multiple exercises/files when doing spelling or other corrections. It makes things very hard to review. 41 files is way too many.
And nothing in the refrence folder (which is not public facing) should be gone thorough. Thanks.
Noted (whitespace + reference)! I will try to split this a bit during the weekend and focus on the important ones.
I’m having a bit of trouble updating the upstream PR (I can only checkout and push changes to my fork), I’m not sure if that’s due to the auto-closing PRs or if I’m missing something.
I’d start over. That PR touches way too many things. And technically, we are not accepting PRs for the track right now.
If you insist, I’d focus on one active concept or concept exercise at a time.
We specifically ask on the Python track that you do NOT run a wholesale spellcheck on whole folders or docs like ABOUT or CONTRIBUTING, exercise design docs, code examples, example.py files, test files, or benchmarking.py files. Thanks.
I took a look at his PRs and I don’t think your advice is applicable here.
Because the typos he fixed mostly exist inside exercises’ approaches, concepts exercise and other internal docs - all the stuffs that only related to each specific track repo and not the overall problem spec repo.
That’s why the php PR only touched 8 files but the python one did 41 .
.
