Tests for exercise "transpose" incomplete

rommudoh · February 3, 2023, 12:56pm

According to exercise description, you should add padding to rows with different length.

The tests don’t cover this, resulting in solutions being accepted that ignore this requirement.

MatthijsBlom · February 3, 2023, 1:05pm

A general point: it always helps to give (preferable minimal) concrete examples.

rommudoh · February 3, 2023, 1:25pm

I dug a bit into the test cases. All these are test cases with equal length of all lines, despite the name of the test case itself:

github.com

exercism/scheme/blob/main/exercises/practice/transpose/test.scm#L15-L65


      
          (test-success "first line longer than second line" equal? transpose
            '(((84 104 101 32 102 111 117 114 116 104 32 108 105 110 101
                   46)
                (84 104 101 32 102 105 102 116 104 32 108 105 110 101 46
                    32)))
            '((84 84) (104 104) (101 101) (32 32) (102 102) (111 105) (117 102)
               (114 116) (116 104) (104 32) (32 108) (108 105) (105 110)
               (110 101) (101 46) (46 32)))
          (test-success "second line longer than first line" equal? transpose
            '(((84 104 101 32 102 105 114 115 116 32 108 105 110 101 46
                   32)
                (84 104 101 32 115 101 99 111 110 100 32 108 105 110 101
                    46)))
            '((84 84) (104 104) (101 101) (32 32) (102 115) (105 101) (114 99)
               (115 111) (116 110) (32 100) (108 32) (105 108) (110 105)
               (101 110) (46 101) (32 46)))
          (test-success "mixed line length" equal? transpose
            '(((84 104 101 32 108 111 110 103 101 115 116 32 108 105 110
                   101 46)
                (65 32 108 111 110 103 32 108 105 110 101 46 32 32 32 32 32)

This file has been truncated. show original