Triangle exercise already complete

TheRealOwenRees · July 11, 2025, 7:22am

I have submitted the below issues. This exercise is already complete when running npm run start, with all tests passing.

I am happy to submit a PR if agreed.

github.com/exercism/reasonml

Triangle exercise is already complete

opened 07:20AM - 11 Jul 25 UTC

closed 07:20AM - 11 Jul 25 UTC

TheRealOwenRees

When running `npm start` in the Triangle exercise, `./src/Triangle.re` is genera…ted with the solution, with all tests passing. Image attached for reference. I believe this is due to the fact that https://github.com/exercism/reasonml/blob/main/exercises/practice/triangle/src/Triangle.re contains the solution already. The other `.re` files in other exercises are empty. `npm run start` generates `Triangle.bs.js` which the tests are compared against, passing all. **Solution** Delete the code from `./src/Triangle.re` in line with the other exercises. The user will have to create this file as they do in other exercises. <img width="706" height="430" alt="Image" src="https://github.com/user-attachments/assets/cfb05fb1-5392-4290-a121-da62396e458e" />

Thanks

TheRealOwenRees · July 11, 2025, 11:23am

submitted a PR, with a comment about an error possibly outside the scope of this fix

IsaacG · July 11, 2025, 12:52pm

github.com/exercism/reasonml

triangle exercise code deleted, to prevent the exercise from passing …

exercism:main ← TheRealOwenRees:hotfix/triangle

opened 11:22AM - 11 Jul 25 UTC

TheRealOwenRees

+1 -15

[Issue #361 - Triangle exercise already complete](https://github.com/exercism/re…asonml/issues/361) - deleted code in `./src/Triangle.re` to prevent `npm run start` from building the completed exercise and therefore passing all tests Running `make` shows the error `./exercises/practice/flower-field/package.json does not match main package.json.` I am not sure if this is within the scope of this fix.

iHiD · July 11, 2025, 1:14pm

Thank you!