Typo found in "bank account" exercise - requesting a PR

Hey, I noticed a typo in the bank account exercise

I would be more than glad to open up a PR regarding this on github (especially that it’s my first contribution), just give me green light, and I’ll get to it! :D

I’m not a maintainer of the C#-Track, but I think it is OK to fix that. Anyway, please wait for the maintainer’s opinion.

This sentence is in the track specific instructions append file exercises/practice/bank-account/.docs/instructions.append.md.

@IsaacG Please move this to Programming C#. cc @ErikSchierboom

Typically we say don’t do anything untill the maintainer gives you the go ahead to open a PR. I’m going to say for this specific issue, I’m pretty sure Erik would welcome a PR and that you can go ahead and open a PR for it.

1 Like

yeah but the thing is that there is a bot that blocks any PR’s immediately so I’m not sure how do I do that without having it closed as soon as I open it.

1 Like

Don’t worry :slight_smile: You open the PR, the bot closes it, the maintainer will re-open it. It will be reviewed and merged then.

Edit: Please link this thread in the PR description and link the PR in a comment here.

1 Like

Alright, I’ll do that then.

Fixed a typo in instructions for bank-account exercise by Nightlite185 · Pull Request #2446 · exercism/csharp · GitHub there you go - link to the PR

3 Likes

heyy now that I got my PR accepted, why do I still have “No PRs accepted” written on my profile on exercism? I was kinda hoping it would change to one and I would get some badge or some other cool thingy XDD

Maybe it’s related to the servers going down yesterday tho and just unlucky timing.

I think it got merged during server outage. If it does not get accounted for in say 2 days, please report again.

1 Like

Make sure you have linked your GitHub account in Integrations.

@keiraville Yeah they’re linked since like a month or more, but thanks. @mk-mxp you wanted me to come back here and let you know so umm yeah I’m here, nothing changed throughout those few days

I think at this point, it’d be something that @iHiD would need to investigate further time permitting.

I just checked Nightlite’s profile on Exercism to see if this has been updated yet, and still seems like it is not. But also now easily checked by going to the link for those that are curious.

1 Like