Unnecessary to_string() calls in the test file of DOT DSL

Programming Rust
1

The calls to to_string() in the following seems redundant. Actually, if they were deleted, it allows slightly cleaner implementation in which the attrs field can have type HashMap<&str, &str> instead of HashMap<String, String>. This serves a good exercise to work with Rust lifetimes. :slight_smile:

Anyway, this change will break the tests of all existing passed solutions.

fn graph_with_one_attribute() {
    let graph = Graph::new().with_attrs(&[("foo", "1")]);

    let expected_attrs = HashMap::from([("foo".to_string(), "1".to_string())]);

    assert!(graph.nodes.is_empty());

    assert!(graph.edges.is_empty());

    assert_eq!(graph.attrs, expected_attrs);
}
2

The point of this exercise is not to practice lifetimes, so I don’t want to force users to do it. Breaking existing solutions also doesn’t seem worth it.

But I found a simple way to allow both: PR

2 Likes