Update chess_game.rb

Horlamedhey · January 12, 2025, 5:53am

The method ‘nick_name’ is not consistent with the instructions’ version (nickname), and since ‘nickname’ is a whole word, it makes sense without the underscore.

IsaacG · January 12, 2025, 5:55am

The code stub contains,

  def self.nick_name(first_name, last_name)
    raise "Please implement the Chess.nick_name method"
  end

github.com

exercism/ruby/blob/main/exercises/concept/chess-game/chess_game.rb#L9


      
          module Chess
            # TODO: define the 'RANKS' constant
            # TODO: define the 'FILES' constant
          
            def self.valid_square?(rank, file)
              raise "Please implement the Chess.valid_square? method"
            end
          
            def self.nick_name(first_name, last_name)
              raise "Please implement the Chess.nick_name method"
            end
          
            def self.move_message(first_name, last_name, square)
              raise "Please implement the Chess.move_message method"
            end
          end

iHiD · January 12, 2025, 1:29pm

Thanks for reporting.

I think in this case we should probably change the stub and tests to match the instructions. nickname is one word as you say, and it’s only been solved by 1.8K people, so I’m ok with invalidating those.

Anyone have contrasting opinions?

glennj · January 12, 2025, 3:05pm

Is there a move in chess where you steal your opponent’s name (nick name)?

kotp · January 12, 2025, 6:57pm

I have reopened the pull request. Let’s get this in!

Unset the draft when you are ready, and I or someone else will approve and bring it in.

kotp · January 12, 2025, 6:59pm

My other reply was more in reply to you, than Isaac. Showing code can be nice, and I gravitated there for that reason, rather than where I should have responded.

Meatball · January 13, 2025, 9:06pm

This has already been updated on the crystal version(for quite a while ago) seems like I forgot to update the Ruby version

kotp · January 15, 2025, 12:36am

I doubt it was really creating problems, so no urgency there. But a space or not a space really can change the meaning .