User solution with logic error

Programming Swift
1

in this solution: https://exercism.org/tracks/swift/exercises/wings-quest/solutions/PedroJoaquim97 in the win function, if I do powerUpActive = true e touchingEagle = true:

!powerUpActive && touchingEagle
!true && true => false && true => false
negating: !false => true

doing !powerUpActive && !touchingEagle like the user:

!powerUpActive && !touchingEagle
!true && !true => false && false => false
2

Yes. The solution could be better. If the user wanted to improve their solution, they could request mentoring and the mentor would hopefully point that out.

3

@IsaacG the problem is that it passed out the tests

4

Okay. Are you suggesting the tests should be improved in some way? What would you suggest changing?

5

@IsaacG to do a test that dont pass this specific case?

6

That sounds reasonable. Is there a specific test you would like to propose here?

7

@IsaacG

#expect(win(hasPickedUpAllSeeds: true, powerUpActive: true, touchingEagle: true))
8

+cc @Meatball as the Swift maintainer to evaluate if this test should be added.