[Wren][D&D Character] Wrong stub

Adrien-ANTON-LUDWIG · December 16, 2023, 5:22pm

The stub seems wrong to me, it contains some JS documented code and a function definition:

exercism/wren/blob/4d8a48cc5f0869544a711b12bd0e4b610694d617/exercises/practice/dnd-character/dnd-character.wren#L1-L7


      
          // export const abilityModifier = () => {
          //   throw new Error('Remove this statement and implement this function');
          // };
          
          var abilityModifier = Fn.new { |n|
            Fiber.abort("Remove this statement and implement this function")
          }

whereas the tests expect a class Util:

github.com

exercism/wren/blob/4d8a48cc5f0869544a711b12bd0e4b610694d617/exercises/practice/dnd-character/dnd-character.spec.wren#L7


      
          import "wren-testie/testie" for Testie, Expect
          import "./dnd-character" for Character, Util
          
          Testie.test("D&D Character") { |do, skip|
            do.describe("Ability modifier") {
              do.test("ability modifier for score 3 is -4") {
                Expect.value(Util.abilityModifier(3)).toEqual(-4)
              }
          
              skip.test("ability modifier for score 4 is -3") {
                Expect.value(Util.abilityModifier(4)).toEqual(-3)
              }
          
              skip.test("ability modifier for score 5 is -3") {
                Expect.value(Util.abilityModifier(5)).toEqual(-3)
              }

Can I create a PR to fix this?

IsaacG · December 16, 2023, 5:57pm

+cc @glennj

glennj · December 16, 2023, 6:55pm

I’ll sort it out. Thanks for reporting!

glennj · December 16, 2023, 7:28pm

You’re absolutely right of course

// export const abilityModifier = () => {
//   throw new Error('Remove this statement and implement this function');
// };

var abilityModifier = Fn.new { |n|
  Fiber.abort("Remove this statement and implement this function")
}

should be

class Util {
  static abilityModifier(n) = {
    Fiber.abort("Remove this statement and implement this function")
  }
}

Would you like to submit a PR?

Adrien-ANTON-LUDWIG · December 16, 2023, 11:11pm

PR opened.