8 new exercises

Programming COBOL
1

Hi,

it seems that the Exercism github repo is closed. I was about to do a pull request and they shut the whole thing down. I have created 8 new exercises for the COBOL track: acronym, all-your-base, atbash-cipherr, binary, circular-buffer, complex-numbers, matching-brackets, pascals-triangle

If you would like to add these to the track, you may find them here: GitHub - kapitaali/exercism-cobol-track: Exercism exercises in COBOL.

2

Hi @kapitaali. The GitHub repo isn’t closed. We just ask people to discuss things they’re doing on this forum before submit PRs, otherwise we get very overloaded with drive-b contributions, which are often very low quality. Your PR is obviously not low-quality and I’ve reopened it :slight_smile:

1 Like
3

I could have appreciated some sort of guidelines as to what is expected when doing a pull request, like if you would need just the .cob and .cut files (which the pull request was about to contain before I realized that there were hidden directories with solutions) or do you need a pull request submitter to solve the exercises. I tried to look around and was not able to find anything. Luckily I did them myself.

This is the main reason we suggest people discuss things before doing PRs btw. A quick chat before getting started can save the contributor and the review tons of time (e.g., a maintainer can comment on one exercise, not eight exercises, and you have to do 8x less refactoring/changing).

That’s not to undermine your work, which I’m very grateful for and am sure is great, but as you say this is your first ever Pull Request, it might be useful to know that most open source projects suggest discussing changes first to help minimise the review/refactoring work :slight_smile:

4

Thank you for your reply. Yes I have pretty much zero idea as to how pull requests work, but your reply is informative and I now know how to do this in the future. But the link that automatically closed the pull request pointed to an Exercism blog post that was talking about something different, so now that you have elaborated on how things work, I might continue contributing.

2 Likes