Hi! Just got redirected here by the github-actions bot when I opened an issue. Quite a newcomer to open-source contributions, but I’m enjoying Exercism and would love to contribute to the platform in baby-steps and this was one of the first things I found:
There’s currently 4 instances of String.prototype.substr() in robot-name.test.ts. It’s been deprecated, so I’m thinking it could be refactored to use String.prototype.slice() instead?
Would be happy to open a PR if it were to be updated.
I found that running yarn format also modified 10 other files not related to this PR, so they aren’t included in this commit. They’re the markdown files that are causing the failing check on main right now. Should I add those changes too, or is it for another issue/PR?
The cleanest approach would be to push another PR first that does a format cleanup. If those format issues block a push, you can lump them into the same PR. I think Erik prefers fewer PRs over many small PRs.
Ahh, yes I agree, it is cleaner for separation of concerns with a separate PR, but I do see why Erik might prefer it bundled into the same PR
Don’t mind doing either, but since the changes are quite small and formatting is recommended, should I just commit them too then? Tests, linting and format checks pass on adding them (they’re changing tildes to backticks in the exercism/caution’s and exercism/note’s in the markdown files)