[Is this the right place for these kind of issues? read that PR should be discussed on the forum before opening.]
I was mentoring a solution for Inventory Management and notice an implementation of decrement_items function pass the tests, although it did not handle the case of an item existing in the list but not in the inventory dictionary.
I suggest adding this test to for checking above case:
Thanks for posting this issue, and for suggesting a test case.
Unfortunately, I can’t see the full content of your code, since the link you provided only shows me the “compare and PR” page, and not the code diff.
However, based on what you’ve entered here I am open to adding this to the exercise. But I want to make sure you follow the conventions already in the test file (which you may have done in your branch, but I can’t see them):
Yes - it is a bit klugey, but setting the test up in this fashion makes it so the student sees a more directed error message in the UI (since this is a concept exercise, and they can’t actually see the tests).
Once you submit the PR, it will be auto-closed. But don’t panic , I’ll get notified and re-open it.
Thanks for taking the time to explain. At first I didn’t see the error_message (at my local test), yet I did see it later on the forked repository. Anyway to avoid potential conflicts, I synced the repository now and re-did it on a new branch.
Opened a new PR for it here (as you wrote, it auto-closed):
Is it OK?
For next time, should I open a PR before posting here?