Rust Say exercise states max value of i64 instead of u64 in docs

Sethi · December 24, 2022, 12:03am

Sorry if this is the wrong place, not sure where to post this since the GitHub repo doesn’t accept community contributions anymore, so I assume I just post it here?

In the exercise “say” - at the bottom it states the following:

Add capability of converting up to the max value for u64: 9,223,372,036,854,775,807.

However, 9,223,372,036,854,775,807 is the max value of i64, not u64.
The max value of u64 is as written in the test cases, 18,446,744,073,709,551,615.

Can this text be updated?

On the side, I had also opened this PR a while back but it was closed. Any thoughts on this?

github.com/exercism/rust

test: add unit test for sum-of-multiples

exercism:main ← SethFalco:sum-of-multiples

opened 07:57PM - 10 Dec 22 UTC

SethFalco

+6 -0

I'm learning Rust, and was wondering why my code was working when I realized `re…duce` is meant to return `None` when the iterable is empty. I did `(0..limit).reduce()` in my answer, but there was no test that passed `0` as the limit, so the case that would cause this error never occurred. Since 0 is a valid u32 integer, perhaps we should have a test that expects a limit of 0 to return 0 rather than be undefined and untested? Before adding this test, my solution passed all tests but would throw an error on 0.